Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set base url for segment #4684

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Conversation

zachaysan
Copy link
Contributor

Changes

Introduce a change to the host parameter of the Segment client in order to support non-default regions. Also includes a migration to set existing segment clients to the default host via the base_url field of the configuration model.

How did you test this code?

Altered existing tests.

@zachaysan zachaysan requested a review from a team as a code owner October 2, 2024 13:55
@zachaysan zachaysan requested review from khvn26 and removed request for a team October 2, 2024 13:55
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:12pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:12pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:12pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4684 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4684 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4684 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4684 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4684 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Uffizzi Preview deployment-56856 was deleted.

@matthewelwell matthewelwell linked an issue Oct 7, 2024 that may be closed by this pull request
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (d0a6caf) to head (a9688fa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4684   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files        1171     1173    +2     
  Lines       40651    40670   +19     
=======================================
+ Hits        39517    39537   +20     
+ Misses       1134     1133    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan requested a review from khvn26 October 9, 2024 13:56
Merged via the queue into main with commit 4e833b8 Oct 10, 2024
35 checks passed
@zachaysan zachaysan deleted the feat/set_base_url_for_segment branch October 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for EU region for Segment
2 participants