Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always store and search dashboard alias in lower case #4676

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Always store and search for dashboard aliases in lower case.

How did you test this code?

Added / updated existing tests.

@matthewelwell matthewelwell requested a review from a team as a code owner October 1, 2024 13:09
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team October 1, 2024 13:09
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 3:53pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 3:53pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 3:53pm

@matthewelwell matthewelwell changed the title Always store and search dashboard alias in lower case fix: always store and search dashboard alias in lower case Oct 1, 2024
@github-actions github-actions bot added the api Issue related to the REST API label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4676 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4676 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4676 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4676 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4676 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4676 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Uffizzi Preview deployment-56801 was deleted.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (4bca509) to head (d8748e4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4676   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files        1166     1166           
  Lines       40436    40452   +16     
=======================================
+ Hits        39301    39317   +16     
  Misses       1135     1135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 22a3083 Oct 2, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/dashboard-alias-lowercase branch October 2, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants