Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: diff check for versioned segment overrides and MV #4656

Merged
merged 14 commits into from
Oct 8, 2024
Merged

fix: diff check for versioned segment overrides and MV #4656

merged 14 commits into from
Oct 8, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 24, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Fixes an issue whereby the frontend doesn't detect changes when adjusting only a segment override value or % weight for versioned change requests.
  • Fixes an issue where creating a mv feature then attempting to edit without refreshing didnt work

This was due to the frontend having access to the raw feature state value rather than the object version {string_value:"eg",...}

Likely related to this PR: #4609.

How did you test this code?

  • Published versions without change requests
  • Updated feature values
  • Updated segment override values
  • Published versions with change requests
  • Created change requests changing feature values and segment override values

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 24, 2024 13:31
@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 1:35pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 1:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 1:35pm

@kyle-ssg kyle-ssg requested review from matthewelwell and removed request for a team September 24, 2024 13:31
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4656 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4656 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4656 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4656 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4656 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4656 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4656 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4656 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4656 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4656 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4656 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4656 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Uffizzi Preview deployment-56586 was deleted.

@kyle-ssg kyle-ssg marked this pull request as draft September 25, 2024 08:59
@kyle-ssg kyle-ssg changed the title fix: diff check for versioned segment overrides fix: diff check for versioned segment overrides and MV Sep 25, 2024
@github-actions github-actions bot added fix and removed fix labels Sep 25, 2024
@github-actions github-actions bot added fix and removed fix labels Sep 25, 2024
@kyle-ssg
Segment override diffs
e016ec7
@kyle-ssg
Merge remote-tracking branch 'origin/fix/change_request_segment_overr…
78ea1d7 
…ide_check' into fix/change_request_segment_override_check

# Conflicts:
#	frontend/common/stores/feature-list-store.ts
@github-actions github-actions bot added fix and removed fix labels Sep 27, 2024
@github-actions github-actions bot removed the fix label Oct 2, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 8, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 8, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 8, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 8, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 8, 2024
@kyle-ssg kyle-ssg requested a review from matthewelwell October 8, 2024 13:41
@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 8d1c22e Oct 8, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the fix/change_request_segment_override_check branch October 8, 2024 13:47
@flagsmithdev flagsmithdev mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell