feat(export): Add support for edge identities data #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
gagantrivedi
force-pushed
the
feat/edge-identities-export
branch
from
73d324a to
63e9961
Compare
github-actions
bot
added
feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4654 +/- ##
==========================================
+ Coverage 97.22% 97.32% +0.10%
==========================================
Files 1172 1176 +4
Lines 40516 41097 +581
==========================================
+ Hits 39390 39997 +607
+ Misses 1126 1100 -26 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
Sep 24, 2024
api/edge_api/identities/export.py
Outdated
| "uuid": uuid.uuid4(), | ||
| "feature_state": [featurestate_uuid], | ||
| "multivariate_feature_option": [mv_feature_option_uuid], | ||
| "percentage_allocation": 100.0, |
There was a problem hiding this comment.
Why is this hard coded to 100.0?
There was a problem hiding this comment.
It's because an identity override can only be 100 percent(for mv)
There was a problem hiding this comment.
As per my comment above, I'm not sure this is strictly true.
There was a problem hiding this comment.
Done, it is not hardcoded anymore
github-actions
bot
added
feature
gagantrivedi
force-pushed
the
feat/edge-identities-export
branch
from
dfc7565 to
9cb31b0
Compare
github-actions
bot
added
feature
github-actions
bot
added
feature
api/edge_api/identities/export.py
Outdated
| "uuid": uuid.uuid4(), | ||
| "feature_state": [featurestate_uuid], | ||
| "multivariate_feature_option": [mv_feature_option_uuid], | ||
| "percentage_allocation": 100.0, |
There was a problem hiding this comment.
As per my comment above, I'm not sure this is strictly true.
gagantrivedi
force-pushed
the
feat/edge-identities-export
branch
from
c503667 to
ad4d74e
Compare
github-actions
bot
added
feature
github-actions
bot
added
feature
matthewelwell
approved these changes
Oct 30, 2024
Co-authored-by: Matthew Elwell <[email protected]>
github-actions
bot
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Add support for exporting edge-identities data(i.e: identities, traits, and feature states)
How did you test this code?
Adds unit test and test manually by exporting(from staging) and loading an organisation locally