Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent signup in backend when PREVENT_SIGNUP set to false #4650

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Sep 20, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #4649.

How did you test this code?

Please describe.

@khvn26 khvn26 requested a review from a team as a code owner September 20, 2024 16:19
@khvn26 khvn26 requested review from zachaysan and removed request for a team September 20, 2024 16:19
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 4:48pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 4:48pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 4:48pm

@github-actions github-actions bot added the api Issue related to the REST API label Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4650 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4650 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4650 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4650 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4650 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4650 Finished ✅ Results

@github-actions github-actions bot added the fix label Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Uffizzi Preview deployment-56493 was deleted.

@khvn26 khvn26 changed the title fix: Prevent signup in backend when PREVENT_SIGNUP set to false fix: Prevent signup in backend when PREVENT_SIGNUP set to false Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (b74adbd) to head (1a79945).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4650   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files        1162     1162           
  Lines       40267    40273    +6     
=======================================
+ Hits        39130    39136    +6     
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Sep 20, 2024
@rolodato rolodato added the security Security updates label Sep 23, 2024
@khvn26 khvn26 added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 24ce3bd Sep 23, 2024
38 checks passed
@khvn26 khvn26 deleted the fix/prevent-signup-in-backend branch September 23, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix security Security updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent signup in backend when PREVENT_SIGNUP set to false
3 participants