Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Webhook integration not rebuilding environment #4641

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Sep 18, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes a problem when adding, updating or removing a webhook integration does not trigger an environment document rebuild.

How did you test this code?

Added a unit test specifically for the case. I did make sure the test was failing without the added changes.

@khvn26 khvn26 requested a review from a team as a code owner September 18, 2024 17:24
@khvn26 khvn26 requested review from matthewelwell and removed request for a team September 18, 2024 17:24
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 18, 2024 5:24pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Sep 18, 2024 5:24pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Sep 18, 2024 5:24pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Sep 18, 2024
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4641 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4641 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4641 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4641 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4641 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4641 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 18, 2024

Uffizzi Preview deployment-56416 was deleted.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (b74adbd) to head (4694bdf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4641   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files        1162     1163    +1     
  Lines       40267    40274    +7     
=======================================
+ Hits        39130    39138    +8     
+ Misses       1137     1136    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 37db0e0 Sep 20, 2024
27 of 35 checks passed
@khvn26 khvn26 deleted the fix/webhook-integration-not-rebuilding-environment branch September 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants