Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Solve delete GitHub integration issue #4622

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Solve #4621

How did you test this code?

Update unit test

@novakzaballa novakzaballa requested a review from a team as a code owner September 11, 2024 16:40
@novakzaballa novakzaballa requested review from gagantrivedi and removed request for a team September 11, 2024 16:40
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 5:29pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 5:29pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 5:29pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Sep 11, 2024
Copy link
Contributor

github-actions bot commented Sep 11, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4622 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4622 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4622 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4622 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4622 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4622 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Uffizzi Preview deployment-56176 was deleted.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (7ac05cd) to head (4a47983).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4622   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files        1160     1160           
  Lines       40159    40165    +6     
=======================================
+ Hits        39022    39028    +6     
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit b4d3310 Sep 23, 2024
35 checks passed
@gagantrivedi gagantrivedi deleted the fix/solve-delete-github-integration-issue branch September 23, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants