Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Detect unchanged feature states when saving versions #4609

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Saving a versioned feature / segment overrides will now correctly detect changes before saving. This also means we can show an error to the user if their save contains no changes

image
image

How did you test this code?

Attempted to save segment overrides / features without changes

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 10, 2024 09:38
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 9:38am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 9:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 10, 2024 9:38am

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4609 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4609 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4609 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4609 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4609 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4609 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Uffizzi Preview deployment-56077 was deleted.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this manually using the preview, and given the code a quick look. All looks good to me.

@matthewelwell matthewelwell added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 0e53baf Sep 10, 2024
31 checks passed
@matthewelwell matthewelwell deleted the feat/detect-unchanged-save-feature branch September 10, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants