fix(versioning): fix issue creating duplicate priority segment overrides #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing segment override
matthewelwell
requested review from
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4603 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 1160 1160
Lines 40107 40126 +19
=======================================
+ Hits 38970 38989 +19
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
|
API component of #4604 |
gagantrivedi
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This tightens up the API to avoid situations where existing segment overrides are sent as updates even though nothing actually changes. Previously this caused an issue where 2 segments would end up with the same priority.
Related issue #4604
How did you test this code?
Added a specific test for the issue found by a customer, ensured that the test failed as seen in the behaviour reported by the customer, and subsequently fixed the test.