Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhook/changed_by): Return name of the master api key #4602

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Sep 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Return name of the master api_key if the change was made using it instead of empty string

How did you test this code?

test cases updated

Return name of the master api_key if the change was made using
it instead of None
@gagantrivedi gagantrivedi requested a review from a team as a code owner September 9, 2024 12:18
@gagantrivedi gagantrivedi requested review from zachaysan and removed request for a team September 9, 2024 12:18
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 0:28am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 0:28am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 0:28am

@github-actions github-actions bot added the api Issue related to the REST API label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4602 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4602 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4602 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4602 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4602 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4602 Finished ✅ Results

@github-actions github-actions bot added the fix label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Uffizzi Preview deployment-56023 was deleted.

@gagantrivedi gagantrivedi requested a review from a team as a code owner September 9, 2024 12:28
@github-actions github-actions bot added docs Documentation updates fix and removed fix docs Documentation updates labels Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (b2a1899) to head (6d1b9ae).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4602   +/-   ##
=======================================
  Coverage   97.15%   97.16%           
=======================================
  Files        1157     1157           
  Lines       40023    40037   +14     
=======================================
+ Hits        38886    38900   +14     
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 1b22cf5 Sep 10, 2024
36 checks passed
@gagantrivedi gagantrivedi deleted the fix/changed_by_for_api_key branch September 10, 2024 04:48
@gagantrivedi gagantrivedi restored the fix/changed_by_for_api_key branch September 19, 2024 08:45
@gagantrivedi gagantrivedi deleted the fix/changed_by_for_api_key branch January 14, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API(webhook): changed_by is empty for changes done using master API key
2 participants