fix(edge-api/tasks): Add change_by_user_id #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add change_by_user_id to avoid old tasks from crashing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4591 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 1156 1157 +1
Lines 39934 40013 +79
=======================================
+ Hits 38797 38876 +79
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
Comment on lines
131
to
133
| def test_call_environment_webhook_for_feature_state_change_with_changed_by_user_id( | ||
| mocker, environment, feature, identity, admin_user | ||
| ): |
There was a problem hiding this comment.
Ahh, we should make pre-commit catch this
| feature: Feature, | ||
| identity: Identity, | ||
| admin_user: FFAdminUser, | ||
| ): |
There was a problem hiding this comment.
Suggested change
| ): | |
| ) -> None: |
matthewelwell
approved these changes
Sep 5, 2024
gagantrivedi
force-pushed
the
fix/wehook-task
branch
from
215c609 to
ed93771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Add change_by_user_id to avoid old tasks from crashing
related: https://github.com/Flagsmith/flagsmith/pull/4561/files
How did you test this code?
Adds a unit test