feat: allow ignore conflicts on scheduled change #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4590 +/- ##
=======================================
Coverage 97.15% 97.15%
=======================================
Files 1156 1157 +1
Lines 39934 39994 +60
=======================================
+ Hits 38797 38857 +60
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
feature
gagantrivedi
approved these changes
Sep 5, 2024
matthewelwell
deleted the
feat/allow-ignore-conflicts-on-scheduled-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR sets out to resolve an issue where it's not possible to schedule consecutive change requests on the same feature. For example, in the case where you want to schedule a slow roll out by changing the segment override on a feature to a different percentage value.
To achieve this, I have added a value to the ChangeRequest model which allows the creator to ignore conflicts.
Currently the use case given in the test will only really be useful when using the API directly but this is the use case for a current customer.
How did you test this code?
Added one long integration style test to test the exact use case for a customer.