Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add subscription cache for new organisations #4587

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Sep 4, 2024

Changes

Fixes #4205

Simple introduction of the organisation subscription cache model on create of organisations. I decided against connecting this to influx / chargebee since the organisation is so new there wouldn't be information there yet.

How did you test this code?

One new little test.

@zachaysan zachaysan requested a review from a team as a code owner September 4, 2024 15:24
@zachaysan zachaysan requested review from gagantrivedi and removed request for a team September 4, 2024 15:24
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 3:19pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 3:19pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 3:19pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4587 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4587 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4587 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4587 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4587 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4587 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Uffizzi Preview deployment-55878 was deleted.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (0c38bda) to head (cef5dcd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4587   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files        1157     1157           
  Lines       40013    40023   +10     
=======================================
+ Hits        38876    38886   +10     
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Sep 5, 2024
@zachaysan zachaysan added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit b2a1899 Sep 6, 2024
35 checks passed
@zachaysan zachaysan deleted the feat/add_subscription_cache_for_new_organisations branch September 6, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an AFTER_CREATE lifecycle hook to create OrganisationSubscriptionInformationCache for new organisations
2 participants