-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app_analytics/cache): use lock to make cache thread safe #4567
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/app_analytics/cache.py
Did you find this useful? React with a 👍 or 👎 |
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4567 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 1154 1154
Lines 39811 39816 +5
=======================================
+ Hits 38674 38679 +5
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Use lock to make cache thread safe
fixes #4562
How did you test this code?
Tested manually to make sure two threads can't update _cache update at the same time