Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edge-v2): Migrate only Edge API-enabled projects #4556

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Aug 29, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This removes Core projects from the Edge V2 migrations.

How did you test this code?

Added a unit test.

@khvn26 khvn26 requested a review from a team as a code owner August 29, 2024 11:11
@khvn26 khvn26 requested review from matthewelwell and removed request for a team August 29, 2024 11:11
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 29, 2024 11:11am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 29, 2024 11:11am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 29, 2024 11:11am

@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4556 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4556 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4556 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4556 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4556 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4556 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Uffizzi Preview deployment-55687 was deleted.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (d083e79) to head (26ebbb0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4556   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files        1152     1152           
  Lines       39683    39688    +5     
=======================================
+ Hits        38498    38503    +5     
  Misses       1185     1185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 9c5ff4f Aug 29, 2024
35 checks passed
@khvn26 khvn26 deleted the fix/edge-v2-migrate-only-edge-projects branch August 29, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants