-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sane defaults for segment_operators, integration_data, saml flags #4554
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Docker builds report
|
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added one specific comment, but I'm also interested to know if / how we plan to keep the defaults in sync with any changes to the flags in production.
I'm also keen to know @kyle-ssg 's opinion on this of course.
|
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Add default values to the FoF flags
segment_operators
,integration_data
, andsaml
. This avoids the following scenario:segment_operators
andsaml
flags are created with the correct values.The flags all still work as usual, but don't break anything if they don't exist in a FoF environment.
integration_data
is a bonus to have integrations work out of the box.How did you test this code?
In a local environment, set up FoF but do not create any flags. These should still work: