feat: Add hubspot cookie tracking #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4539 +/- ##
=======================================
Coverage 97.15% 97.16%
=======================================
Files 1157 1160 +3
Lines 40023 40107 +84
=======================================
+ Hits 38886 38970 +84
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
khvn26
reviewed
Aug 28, 2024
khvn26
reviewed
Aug 28, 2024
api/organisations/invites/views.py
Outdated
Comment on lines
49
to
57
| hubspot_cookie = request.COOKIES.get(HUBSPOT_COOKIE_NAME) | ||
|
|
||
| if hubspot_cookie: | ||
| if not HubspotTracker.objects.filter(user=request.user).exists(): | ||
| HubspotTracker.objects.create( | ||
| user=request.user, | ||
| hubspot_cookie=hubspot_cookie, | ||
| ) | ||
|
|
There was a problem hiding this comment.
I'd like to avoid code duplication, which occurs further in join_organisation_from_link. This code can be extracted to either of the following:
- A
HubspotTrackerclass method - A function in
services.py— that's how I'd do it, see existingservices.pymodules for reference
There was a problem hiding this comment.
Sure this is easy.
khvn26
reviewed
Aug 28, 2024
api/organisations/invites/views.py
Outdated
Comment on lines
76
to
83
| hubspot_cookie = request.COOKIES.get(HUBSPOT_COOKIE_NAME) | ||
|
|
||
| if hubspot_cookie: | ||
| if not HubspotTracker.objects.filter(user=request.user).exists(): | ||
| HubspotTracker.objects.create( | ||
| user=request.user, | ||
| hubspot_cookie=hubspot_cookie, | ||
| ) |
khvn26
reviewed
Aug 28, 2024
api/organisations/views.py
Outdated
Comment on lines
114
to
121
| hubspot_cookie = request.COOKIES.get(HUBSPOT_COOKIE_NAME) | ||
|
|
||
| if hubspot_cookie: | ||
| if not HubspotTracker.objects.filter(user=request.user).exists(): | ||
| HubspotTracker.objects.create( | ||
| user=request.user, | ||
| hubspot_cookie=hubspot_cookie, | ||
| ) |
khvn26
reviewed
Aug 28, 2024
api/organisations/invites/views.py
Outdated
|
|
||
| if hubspot_cookie: | ||
| if not HubspotTracker.objects.filter(user=request.user).exists(): | ||
| HubspotTracker.objects.create( |
There was a problem hiding this comment.
Do we need to update the stored cookie in case it's regenerated for some reason?
There was a problem hiding this comment.
Sure, I've switched the code to an update_or_create method to handle that if it ever comes up.
khvn26
requested changes
Aug 28, 2024
gagantrivedi
approved these changes
Sep 4, 2024
| @@ -58,6 +58,12 @@ def create_lead(self, user: FFAdminUser, organisation: Organisation = None) -> N | |||
|
|
|||
| HubspotLead.objects.create(user=user, hubspot_id=response["id"]) | |||
|
|
|||
| if HubspotTracker.objects.filter(user=user).exists(): | |||
There was a problem hiding this comment.
nit: we can use walrus here and get rid of the exists
github-actions
bot
added
feature
khvn26
approved these changes
Sep 6, 2024
Co-authored-by: Kim Gustyr <[email protected]>
github-actions
bot
added
feature
github-actions
bot
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3855
This change adds in a form in the background of a Hubspot contact creation to add in the special Hubspot tracking cookie to give extra visibility in our user's journey in places like the activity tab of the Hubspot dashboard.
How did you test this code?
Manually tested it with my own Hubspot cookie and I added programatic tests after gaining confidence that it worked.