Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ldap-login): create custom serializer to fix login field #4535

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Aug 23, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add a custom login serializer to make login field configurable because LDAP supports login using username/password instead of email/password

How did you test this code?

Adds a unit test

@gagantrivedi gagantrivedi requested a review from a team as a code owner August 23, 2024 04:02
@gagantrivedi gagantrivedi requested review from zachaysan and removed request for a team August 23, 2024 04:02
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 10:10am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 10:10am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 27, 2024 10:10am

@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4535 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4535 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4535 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4535 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4535 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 23, 2024

Uffizzi Preview deployment-55500 was deleted.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (5e02eb4) to head (96640be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4535      +/-   ##
==========================================
+ Coverage   96.94%   96.98%   +0.04%     
==========================================
  Files        1180     1180              
  Lines       39679    39682       +3     
==========================================
+ Hits        38467    38487      +20     
+ Misses       1212     1195      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Aug 27, 2024
@github-actions github-actions bot added fix and removed fix labels Aug 27, 2024
@gagantrivedi gagantrivedi added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit a704c7c Aug 27, 2024
35 checks passed
@gagantrivedi gagantrivedi deleted the fix/ldap-login branch August 27, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants