Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing permissions for LaunchDarkly view #4531

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Aug 22, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This adds the IsAuthenticated permission to the LD import request view, and moves the permission logic out of the view actions.

How did you test this code?

Ran existing unit tests and updated a relevant one.

@khvn26 khvn26 requested a review from a team as a code owner August 22, 2024 16:58
@khvn26 khvn26 requested review from novakzaballa and removed request for a team August 22, 2024 16:58
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 5:18pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 5:18pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 5:18pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4531 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4531 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4531 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4531 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4531 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4531 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Uffizzi Preview deployment-55480 was deleted.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (cd99a07) to head (42b1d3a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4531   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files        1180     1180           
  Lines       39670    39679    +9     
=======================================
+ Hits        38457    38467   +10     
+ Misses       1213     1212    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Aug 22, 2024
@github-actions github-actions bot added fix and removed fix labels Aug 22, 2024
@khvn26 khvn26 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 5e02eb4 Aug 22, 2024
35 checks passed
@khvn26 khvn26 deleted the fix/missing-permissions-ld-view branch August 22, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants