fix: Missing permissions for integration API endpoints #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4530 +/- ##
==========================================
- Coverage 96.92% 96.91% -0.02%
==========================================
Files 1178 2360 +1182
Lines 39623 79340 +39717
==========================================
+ Hits 38405 76891 +38486
- Misses 1218 2449 +1231 ☔ View full report in Codecov by Sentry. |
|
Uffizzi Preview |
Docker builds report
|
matthewelwell
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
This fixes an issue when a previously non-existent environment or project integration can be created for a project a user does not belong to.
The base integration view are refactored to use proper permissions rather than current hacky queryset filtration that did not get applied for the
createaction.How did you test this code?
Added unit tests reproducing the problem for an environment and a project-level integration.