fix: usage and analytics data duplicates the current day #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
|
Uffizzi Preview |
khvn26
reviewed
Aug 21, 2024
khvn26
approved these changes
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4529 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 1178 1178
Lines 39623 39623
=======================================
Hits 38405 38405
Misses 1218 1218 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This code fixes an issue where the current day was duplicated in the usage / analytics graphs and all other days seemed to be off by one.
The reason for this was that the influx query was using the end of the aggregation window to use as the key for the data. This PR updates all uses of
aggregateWindowin the code to use the start of the window as the key.Note that this will mean that we get e.g. 91 results when asking for the last 90 days because it's essentially requesting the exact last (90 x 24h), so it will include today and the same chunk of the first day in the period. Without overcomplicating the query in Influx this would be difficult to solve and I think is perfectly acceptable for now.
Reference: https://docs.influxdata.com/flux/v0/stdlib/universe/aggregatewindow/#timesrc
How did you test this code?
I have updated the (mocked) tests, but obviously this isn't very useful.
@zachaysan and I ran the code against influx directly from my laptop and verified that the data was correct.