Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: usage period filter #4526

Merged
merged 7 commits into from
Aug 21, 2024
Merged

feat: usage period filter #4526

merged 7 commits into from
Aug 21, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

image

  • For paid projects, add a usage filter.
  • Add ability to select api call types

How did you test this code?

As above

@kyle-ssg kyle-ssg requested a review from a team as a code owner August 21, 2024 12:18
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team August 21, 2024 12:18
@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 1:21pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 1:21pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 1:21pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4526 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4526 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4526 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4526 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4526 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4526 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4526 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4526 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4526 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4526 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4526 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4526 Finished ✅ Results ✅

@kyle-ssg kyle-ssg linked an issue Aug 21, 2024 that may be closed by this pull request
Organisation usage charts should show data for current billing period #3406
Closed
@kyle-ssg kyle-ssg changed the title Feat/usage period filter feat: usage period filter Aug 21, 2024
@matthewelwell
Copy link
Contributor

We should get rid of / update this alert too

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

Uffizzi Preview deployment-55420 was deleted.

@github-actions github-actions bot added the feature New feature or request label Aug 21, 2024
@matthewelwell
Copy link
Contributor

Since each of these requests triggers a request to influx (that we pay for), we should also optimise this:

image

We're making a request to the root endpoint, and then with the period=current_billing_period query parameter set when we first load the page (where the default is current_billing_period).

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 21, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 21, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 968b894 Aug 21, 2024
31 checks passed
@matthewelwell matthewelwell deleted the feat/usage-period-filter branch August 21, 2024 17:02
@flagsmithdev flagsmithdev mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@novakzaballa novakzaballa novakzaballa approved these changes

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organisation usage charts should show data for current billing period
3 participants
@kyle-ssg @matthewelwell @novakzaballa