fix: subscription info cache race condition #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
matthewelwell
changed the title
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4518 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 1178 1178
Lines 39515 39528 +13
=======================================
+ Hits 38296 38310 +14
+ Misses 1219 1218 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes race condition(s) related to the cancellation of a subscription. Related sentry issue here.
As far as I can tell from doing some manual testing locally by running the API and pointing it to the staging database, there were likely 2 issues in the code here:
BEFORE_DELETEhook on the organisation model which cancelled the subscription if it was paid. This involved deleting the relatedOrganisationSubscriptionInformationCacheobject, but the execution path then continued to delete the organisation, and subsequently try and cascade delete the OSIC object. This would fail (seemingly only some of the time).How did you test this code?
I have updated a unit test to test the new behaviour, however, (perhaps more importantly) I have also tested this locally to confirm I can delete an organisation that I was previously unable to delete due to the related sentry issue.