-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(views/features): use get_environment_flags_list #4511
Conversation
get_live_feature_states doesn't take live_from into account when returning feature states, which can result in feature states with less recent live_from values being returned.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/features/views.py
Did you find this useful? React with a 👍 or 👎 |
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4511 +/- ##
==========================================
- Coverage 96.92% 96.92% -0.01%
==========================================
Files 1178 1178
Lines 39490 39489 -1
==========================================
- Hits 38276 38275 -1
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
get_live_feature_states
withget_environment_flags_list
Why:
get_live_feature_states
doesn't takelive_from
into account when returning feature states, which can result in feature states with less recent live_from values being returned.How did you test this code?
Covered by updated unit test