Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(views/features): use get_environment_flags_list #4511

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Aug 19, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Replace get_live_feature_states with get_environment_flags_list

Why: get_live_feature_states doesn't take live_from into account when returning feature states, which can result in feature states with less recent live_from values being returned.

How did you test this code?

Covered by updated unit test

get_live_feature_states doesn't take live_from into account when
returning feature states, which can result in feature states with less recent
live_from values being returned.
@gagantrivedi gagantrivedi requested a review from a team as a code owner August 19, 2024 13:08
@gagantrivedi gagantrivedi requested review from khvn26 and removed request for a team August 19, 2024 13:08
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 19, 2024 1:08pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 19, 2024 1:08pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 19, 2024 1:08pm

@github-actions github-actions bot added the api Issue related to the REST API label Aug 19, 2024
Copy link

sentry-io bot commented Aug 19, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: api/features/views.py

Function Unhandled Issue
get_queryset ValueError: invalid literal for int() with base 10: 'undefined' /api/v1/environments/{environment_api_key}...
Event Count: 147

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the fix label Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4511 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4511 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4511 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4511 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4511 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4511 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Uffizzi Preview deployment-55348 was deleted.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (174d437) to head (fe4f0cb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4511      +/-   ##
==========================================
- Coverage   96.92%   96.92%   -0.01%     
==========================================
  Files        1178     1178              
  Lines       39490    39489       -1     
==========================================
- Hits        38276    38275       -1     
  Misses       1214     1214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 7034fa4 Aug 19, 2024
35 checks passed
@gagantrivedi gagantrivedi deleted the fix/feature-env-fs branch August 19, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants