Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(delete-feature-via-role): bump rbac #4508

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix(delete-feature-via-role): bump rbac #4508

merged 1 commit into from
Aug 16, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Aug 16, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Bump rbac to fix #4506

How did you test this code?

Tested manually and a test cases was added in the rbac repo

@gagantrivedi gagantrivedi requested a review from a team as a code owner August 16, 2024 08:40
@gagantrivedi gagantrivedi requested review from novakzaballa and removed request for a team August 16, 2024 08:40
Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 16, 2024 8:40am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 16, 2024 8:40am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 16, 2024 8:40am

@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 16, 2024
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4508 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4508 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4508 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4508 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4508 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4508 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 16, 2024

Uffizzi Preview deployment-55306 was deleted.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (cb8472d) to head (70914bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4508   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files        1178     1178           
  Lines       39490    39490           
=======================================
  Hits        38276    38276           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added api Issue related to the REST API and removed api Issue related to the REST API labels Aug 16, 2024
@gagantrivedi gagantrivedi added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 174d437 Aug 16, 2024
35 of 36 checks passed
@gagantrivedi gagantrivedi deleted the fix/4506 branch August 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete feature when using permission via role assigned to a group
2 participants