Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make pg usage cache timeout configurable #4485

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Aug 13, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add env var PG_API_USAGE_CACHE_SECONDS to allow user to set the timeout

How did you test this code?

covered by unit tests

@gagantrivedi gagantrivedi requested a review from a team as a code owner August 13, 2024 05:58
@gagantrivedi gagantrivedi requested review from matthewelwell and removed request for a team August 13, 2024 05:58
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 13, 2024 5:58am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 13, 2024 5:58am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 13, 2024 5:58am

Copy link

sentry-io bot commented Aug 13, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: api/app_analytics/cache.py

Function Unhandled Issue
track_request RuntimeError: dictionary changed size during iteration /api/v1/ident...
Event Count: 15

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the api Issue related to the REST API label Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4485 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4485 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4485 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4485 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4485 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4485 Finished ✅ Results

@github-actions github-actions bot added the feature New feature or request label Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Uffizzi Preview deployment-55196 was deleted.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (6660af5) to head (e586b4d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4485   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files        1176     1176           
  Lines       39348    39349    +1     
=======================================
+ Hits        38134    38135    +1     
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit cd4fbe7 Aug 13, 2024
35 checks passed
@matthewelwell matthewelwell deleted the feat/make-usage-cache-configurable branch August 13, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants