Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create a check for billing started at in API usage task helper #4440

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

zachaysan
Copy link
Contributor

Changes

Check when billing_starts_at is None and log it and return from the function.

How did you test this code?

One new test which checks the error behaviour. Existing tests can cover normal operation.

@zachaysan zachaysan requested a review from a team as a code owner July 31, 2024 14:39
@zachaysan zachaysan requested review from matthewelwell and removed request for a team July 31, 2024 14:39
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 2:40pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 2:40pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 31, 2024 2:40pm

@github-actions github-actions bot added the api Issue related to the REST API label Jul 31, 2024
@zachaysan zachaysan requested review from a team and novakzaballa and removed request for matthewelwell and a team July 31, 2024 14:39
@github-actions github-actions bot added the fix label Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4440 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4440 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4440 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4440 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4440 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4440 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Uffizzi Preview deployment-54861 was deleted.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (f03b479) to head (c6a9024).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4440   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files        1170     1170           
  Lines       38786    38801   +15     
=======================================
+ Hits        37566    37581   +15     
  Misses       1220     1220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaysan zachaysan added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit e2853d7 Aug 1, 2024
34 checks passed
@zachaysan zachaysan deleted the fix/create_a_check_for_billing_started_at branch August 1, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants