-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Create a check for billing started at in API usage task helper #4440
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4440 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 1170 1170
Lines 38786 38801 +15
=======================================
+ Hits 37566 37581 +15
Misses 1220 1220 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Check when
billing_starts_at
isNone
and log it and return from the function.How did you test this code?
One new test which checks the error behaviour. Existing tests can cover normal operation.