feat(versioning): limit returned number of versions by plan #4433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4433 +/- ##
==========================================
+ Coverage 97.22% 97.29% +0.07%
==========================================
Files 1172 1173 +1
Lines 40537 40799 +262
==========================================
+ Hits 39411 39697 +286
+ Misses 1126 1102 -24 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
feature
gagantrivedi
previously approved these changes
Aug 5, 2024
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
gagantrivedi
approved these changes
Sep 10, 2024
…rsions-by-plan # Conflicts: # api/tests/unit/features/versioning/test_unit_versioning_views.py
github-actions
bot
added
feature
…rsions-by-plan # Conflicts: # api/tests/unit/sales_dashboard/test_unit_sales_dashboard_views.py
github-actions
bot
added
feature
github-actions
bot
added
feature
matthewelwell
deleted the
feat(versioning)/configure-num-versions-by-plan
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR primarily sets out to implement a limit on the number of versions returned for a given subscription plan. As part of the discussions related to this functionality, however, I have implemented (in this same PR) a similar limit on the audit log records.
Some things we'll need to do outside of the deployment of this:
How did you test this code?
Added / updated unit tests.