Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: users with CREATE_FEATURE permission cannot assign feature users / groups #4371

Merged

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes a mismatch in the permissions between the FE and the BE. The FE was requiring project admin to assign users / groups to a feature whereas it should let anyone with CREATE_FEATURE.

One thing that would be good to add to this (but beyond my expertise) is to show these data read only to all users.

How did you test this code?

Tested the following scenarios locally:

  • User without CREATE_FEATURE cannot assign users / groups
  • User with CREATE_FEATURE can assign users / groups
  • User with Project Admin can assign users / groups

@matthewelwell matthewelwell requested a review from a team as a code owner July 23, 2024 14:08
@matthewelwell matthewelwell requested review from novakzaballa and removed request for a team July 23, 2024 14:08
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:08pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 2:08pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 23, 2024 2:08pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jul 23, 2024
Copy link
Contributor

github-actions bot commented Jul 23, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4371 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4371 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4371 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4371 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4371 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4371 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Uffizzi Preview deployment-54522 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit d0f3704 Jul 23, 2024
29 of 30 checks passed
@matthewelwell matthewelwell deleted the fix/assign-users-groups-with-create-feature-permission branch July 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants