Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub integration - styling issues #4349

Closed
kyle-ssg opened this issue Jul 17, 2024 · 0 comments · Fixed by #4498
Closed

GitHub integration - styling issues #4349

kyle-ssg opened this issue Jul 17, 2024 · 0 comments · Fixed by #4498
Assignees

Comments

@kyle-ssg
Copy link
Member

kyle-ssg commented Jul 17, 2024

Is your feature request related to a problem? Please describe.

There are a few stylistic changes that would improve the integration

Describe the solution you'd like.

These will look better if they are inline rather than on separate rows
image

Replace loading state with a center
image

Remove margin bottom from select options, just use standard styles
image

We are showing a no external resources linked as well as the ui to add in the center, this looks quite strange I think we have 2 options

1 - Left align the "You have no" text
2 - Remove the messaging

Linking an additional item UI should be above existing, it looks a bit strange it being underneath.

The save button feels unnecessary, we may as well just apply it when an item is selected
image

Link icon overflowing to new line
image

Describe alternatives you've considered

N/A

Additional context

No response

@kyle-ssg kyle-ssg linked a pull request Aug 28, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants