fix: Update of organisations during flags and admin access #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4344 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 1159 1159
Lines 38079 38080 +1
=======================================
+ Hits 36852 36853 +1
Misses 1227 1227 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Jul 18, 2024
zachaysan
deleted the
fix/update_of_organisations_during_flags_and_admin_access
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There is code to automatically rebuild the environment document when API access has been enabled / disabled, but it relies on lifecycle hooks which only get called when models are saved individually. So the bulk update of the organisations around (un)restricting has been loosed to just normal
.save()calls.How did you test this code?
Since the import in the lifecycle hook code is local, I was unable to create a mock to verify the calls individually, so I just dropped a
breakpoint()in the local section and verified that the relevant code was called from the pre-existing method.