fix: Non-admin users cannot link a feature to a GH Issue/PR #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4336 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 1159 1159
Lines 38069 38079 +10
=======================================
+ Hits 36842 36852 +10
Misses 1227 1227 ☔ View full report in Codecov by Sentry. |
novakzaballa
force-pushed
the
fix/non-admin-users-cannot-link-a-feature-to-a-gh-issue-pr
branch
from
40ec824 to
2a9bcc4
Compare
zachaysan
approved these changes
Jul 15, 2024
| @@ -189,18 +189,20 @@ def has_object_permission(self, request, view, obj): | |||
|
|
|||
|
|
|||
| class GithubIsAdminOrganisation(NestedIsOrganisationAdminPermission): | |||
| def has_permission(self, request, view): | |||
| def has_permission(self, request, view) -> bool: | |||
There was a problem hiding this comment.
Suggested change
| def has_permission(self, request, view) -> bool: | |
| def has_permission(self, request: Request, view: GenericViewSet) -> bool: |
| if isinstance(request.user, FFAdminUser): | ||
| return request.user.is_organisation_admin( | ||
| Organisation.objects.get(pk=organisation_pk) | ||
| ) | ||
| else: | ||
| return request.user.is_master_api_key_user | ||
|
|
||
| def has_object_permission(self, request, view, obj): | ||
| def has_object_permission(self, request, view, obj) -> bool: |
| # When | ||
| response = staff_client.get(url) | ||
| # Then | ||
| assert response.status_code == status.HTTP_200_OK |
There was a problem hiding this comment.
Can we add additional assertions here like testing that the GitHub configuration looks like something we expect?
novakzaballa
force-pushed
the
fix/non-admin-users-cannot-link-a-feature-to-a-gh-issue-pr
branch
from
3fa14a9 to
2dc2eaf
Compare
novakzaballa
deleted the
fix/non-admin-users-cannot-link-a-feature-to-a-gh-issue-pr
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Granting a non-admin user permission to view the repositories integrated with Flagsmith allows them to link issues/PRs with features in the UI
How did you test this code?
Unit test added