fix: The organisation setting page is broken locally #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
front-end
Docker builds report
|
|
Uffizzi Preview |
There was a problem hiding this comment.
These don't look right to me based on our conversation @kyle-ssg ?
khvn26
approved these changes
Jul 12, 2024
@matthewelwell , I'm sorry, maybe I'm missing something, but this is not related to the announcement flag. It's related to changes in the Payment file, for example: data-cb-plan-id={Project.plans.startup.annual} |
kyle-ssg
reviewed
Jul 12, 2024
| @@ -16,6 +16,10 @@ module.exports = global.Project = { | |||
| flagsmithClientEdgeAPI: 'https://edge.api.flagsmith.com/api/v1/', | |||
| // This is used for Sentry tracking | |||
| maintenance: false, | |||
| plans: { | |||
There was a problem hiding this comment.
plans: {
scaleUp: { annual: 'scale-up-annual-v2', monthly: 'scale-up-v2' },
startup: { annual: 'startup-annual-v2', monthly: 'startup-v2' },
},
There was a problem hiding this comment.
@novakzaballa this is what I was getting at.
kyle-ssg
approved these changes
Jul 12, 2024
novakzaballa
deleted the
fix/the-organisation-setting-page-is-broken-locally
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
planskey in the project_local fileHow did you test this code?