fix(get_permitted_projects): get rid of distinct #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Uffizzi Preview |
gagantrivedi
force-pushed
the
fix/4242/optimize-query
branch
from
a8040e5 to
4d03569
Compare
gagantrivedi
force-pushed
the
fix/4242/optimize-query
branch
from
4d03569 to
4e35608
Compare
Use multiple small queries instead of distinct for better performance
gagantrivedi
force-pushed
the
fix/4242/optimize-query
branch
from
db84759 to
ebe2dfb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4320 +/- ##
=======================================
Coverage 96.60% 96.61%
=======================================
Files 1196 1196
Lines 39113 39123 +10
=======================================
+ Hits 37787 37797 +10
Misses 1326 1326 ☔ View full report in Codecov by Sentry. |
|
|
|
|
|
|
|
|
|
|
gagantrivedi
force-pushed
the
fix/4242/optimize-query
branch
from
4ada29b to
3b26f65
Compare
gagantrivedi
force-pushed
the
fix/4242/optimize-query
branch
from
3b26f65 to
44f4755
Compare
khvn26
reviewed
Jul 10, 2024
| object_ids.update( | ||
| list(for_model.objects.filter(group_filter).values_list("id", flat=True)) | ||
| ) | ||
| if settings.IS_RBAC_INSTALLED: |
There was a problem hiding this comment.
Suggested change
| if settings.IS_RBAC_INSTALLED: | |
| if settings.IS_RBAC_INSTALLED: # pragma: no cover |
This will exclude all the code from the if branch.
gagantrivedi
force-pushed
the
fix/4242/optimize-query
branch
from
44f4755 to
ed8727e
Compare
gagantrivedi
force-pushed
the
fix/4242/optimize-query
branch
from
ed8727e to
50d141e
Compare
matthewelwell
approved these changes
Jul 10, 2024
| @@ -3102,7 +3121,7 @@ def test_feature_list_last_modified_values( | |||
| Feature.objects.create(name=f"feature_{i}", project=project) | |||
|
|
|||
| # When | |||
| with django_assert_num_queries(19): # TODO: reduce this number of queries! | |||
| with django_assert_num_queries(18): # TODO: reduce this number of queries! | |||
There was a problem hiding this comment.
Nice! First time I've actually seen this number go down in a while! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Refactor get_permitted_projects_for_user to use 4 small queries(each taking less than 1ms) instead of one giant query using distinct
Feature permission: Let view do the permission check for
listactionHow did you test this code?
Adds/updates unit tests