feat: Announcement per page FF accept params #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
front-end
|
Uffizzi Preview |
kyle-ssg
reviewed
Jul 2, 2024
| exact: false, | ||
| path: routes[page], | ||
| strict: false, | ||
| }) | ||
| if (match) { | ||
| if ( | ||
| parseInt(get(match, 'params.projectId')!) !== |
There was a problem hiding this comment.
I think this could be more generic
- Put projectId under a params object
- Check if announcementPerPageValue.params
- If there are params match all params
- String both sides rather than assuming the params are int
There was a problem hiding this comment.
Okay, I think I understood you, done.
github-actions
bot
added
feature
novakzaballa
changed the title
kyle-ssg
reviewed
Jul 2, 2024
|
|
||
| if (match) { | ||
| const annParams = | ||
| convertObjectValuesToStrings(announcementPerPageValue?.params) || {} |
There was a problem hiding this comment.
Is any of the convert objects to strings necessary? Can't you just adjust line 67 to
return Object.keys(obj1).every((key) => {
return `${obj1[key]}` === `${obj2[key]}`
})
kyle-ssg
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
How did you test this code?
paramsto the value of your feature flagAnnouncement_per_page, and set the value to the IDs of the project, environment, or organisation, where you want the announcement to be displayed.The params key can have the following values: projectId, environmentId, and organisationId.(They are not mandatory)
This is an example of how the flag's value should appear with the params key.