feat(api usage): Extra Flagsmith checks for API overage charges #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_period_over task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
github-actions
bot
added
api
matthewelwell
approved these changes
Jun 26, 2024
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4251 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 1190 1190
Lines 38754 38804 +50
=======================================
+ Hits 37426 37476 +50
Misses 1328 1328 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a simple change to introduce another Flagsmith feature check for one of the more dangerous tasks that we have in the API usage alerting code.
How did you test this code?
The change also fixes a number of tests that broke with the change and introduces a large test for checking whether the Flagsmith client will successfully guard against non-use when disabled.