Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-usage): add subscription.plan trait to flagsmith.get_identity_flags #4247

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Adds the subscription.plan trait to the call to flagsmith.get_identity_flags so that we can segment on only free plan users for example.

How did you test this code?

Updated existing unit test to assert correct traits are added.

@matthewelwell matthewelwell requested a review from zachaysan June 26, 2024 13:44
@matthewelwell matthewelwell requested a review from a team as a code owner June 26, 2024 13:44
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 26, 2024 1:44pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 26, 2024 1:44pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 26, 2024 1:44pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 26, 2024
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Uffizzi Preview deployment-53526 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 182ea04 Jun 26, 2024
28 checks passed
@matthewelwell matthewelwell deleted the feat(api-usage)/add-subscription-plan-trait branch June 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants