Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Use correct ENV value for production #4237

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jun 25, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This provides correct ENV value to E2E tests ran against production.

How did you test this code?

This is a CI change.

@khvn26 khvn26 requested a review from kyle-ssg June 25, 2024 20:32
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 25, 2024 8:32pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 25, 2024 8:32pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 25, 2024 8:32pm

@github-actions github-actions bot added the fix label Jun 25, 2024
Copy link
Contributor

github-actions bot commented Jun 25, 2024

Uffizzi Preview deployment-53497 was deleted.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (a3bae58) to head (8c52f51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4237   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files        1190     1190           
  Lines       38754    38754           
=======================================
  Hits        37426    37426           
  Misses       1328     1328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyle-ssg kyle-ssg added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 81753ba Jun 26, 2024
29 checks passed
@kyle-ssg kyle-ssg deleted the fix/correct-env-prod branch June 26, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants