Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add logic to API usage notification templates #4206

Merged

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Updated the templates to include logic that is customized towards whether an organisation is a paid account or not.

How did you test this code?

Updated existing tests which had coverage, verifying the free / paid distinction.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 20, 2024 8:24pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 20, 2024 8:24pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 20, 2024 8:24pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Uffizzi Preview deployment-53306 was deleted.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (e1f3a7b) to head (b295d39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4206   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files        1177     1177           
  Lines       38290    38293    +3     
=======================================
+ Hits        36956    36959    +3     
  Misses       1334     1334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan requested a review from matthewelwell June 21, 2024 12:28
@matthewelwell matthewelwell added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 6afa63d Jun 21, 2024
25 checks passed
@matthewelwell matthewelwell deleted the feat/add_logic_to_api_usage_notification_templates branch June 21, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants