Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show new version warning in change requests #4153

Merged

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 12, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Adds a warning if a version has been published for the same feature since the creation of a change request
  • Fixes change request paging when user clicks directly on the number
  • The compare to live was checking against all versions, this meant that if you had a scheduled flag it'd compare to that
image

How did you test this code?

  • Create 2 change requests
  • Publish one
  • View the other

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 9:00am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 9:00am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 9:00am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jun 12, 2024
@kyle-ssg kyle-ssg changed the title chore:Show new version warning in change requests chore: Show new version warning in change requests Jun 12, 2024
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Uffizzi Preview deployment-52962 was deleted.

@matthewelwell
Copy link
Contributor

Can we add a similar warning to the confirm dialog?

image

@kyle-ssg
Copy link
Member Author

image
Added

@matthewelwell matthewelwell changed the title chore: Show new version warning in change requests feat: Show new version warning in change requests Jun 13, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 69f6ae6 Jun 13, 2024
17 checks passed
@matthewelwell matthewelwell deleted the chore/show_change_request_warning_when_newer_version_exists branch June 13, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants