Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrate_analytics): fix migrate_to_pg command #4139

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jun 11, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

fix influx query to migrate analytics data

How did you test this code?

  • updates unit tests
  • tested manually in a minikube cluster with our helm chart

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 5:27am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 5:27am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 5:27am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jun 11, 2024
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Uffizzi Preview deployment-52864 was deleted.

@github-actions github-actions bot added fix and removed fix labels Jun 11, 2024
@gagantrivedi gagantrivedi requested review from a team and matthewelwell and removed request for a team June 11, 2024 05:29
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (e217df7) to head (fd7c1d4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4139      +/-   ##
==========================================
- Coverage   96.49%   96.49%   -0.01%     
==========================================
  Files        1174     1174              
  Lines       38123    38122       -1     
==========================================
- Hits        36788    36787       -1     
  Misses       1335     1335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi marked this pull request as ready for review June 11, 2024 09:31
@github-actions github-actions bot added fix and removed fix labels Jun 11, 2024
@gagantrivedi gagantrivedi added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit c0f373a Jun 12, 2024
29 checks passed
@gagantrivedi gagantrivedi deleted the fix/migrate-analytics-command branch June 12, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants