Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Edge V2-enabled environments are not rebuilt on feature version publish #4132

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jun 7, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes the issue when some environment updates don't trigger an flagsmith_environments_v2 update.

How did you test this code?

Updated the relevant unit test.

@khvn26 khvn26 requested review from a team and zachaysan and removed request for a team June 7, 2024 18:32
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 7, 2024 6:32pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 7, 2024 6:32pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 7, 2024 6:32pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Uffizzi Preview deployment-52798 was deleted.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (e217df7) to head (87cc6c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4132      +/-   ##
==========================================
- Coverage   96.49%   96.49%   -0.01%     
==========================================
  Files        1174     1174              
  Lines       38123    38120       -3     
==========================================
- Hits        36788    36785       -3     
  Misses       1335     1335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 7e0c9fd Jun 11, 2024
22 checks passed
@matthewelwell matthewelwell deleted the fix/rebuild-environment-document-with-v2 branch June 11, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants