Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All code examples should be instance-aware #4130

Closed
khvn26 opened this issue Jun 7, 2024 · 1 comment · Fixed by #4436 or #4807
Closed

All code examples should be instance-aware #4130

khvn26 opened this issue Jun 7, 2024 · 1 comment · Fixed by #4436 or #4807
Assignees
Labels
front-end Issue related to the React Front End Dashboard good first issue Good for newcomers improvement Improvement to the existing platform

Comments

@khvn26
Copy link
Member

khvn26 commented Jun 7, 2024

Thanks to @rolodato for reporting this.

For every Flagsmith deployment besides the default Flagsmith SaaS environment, a correct base URL should be added to all SDK init code in all of the code examples.

@matthewelwell matthewelwell added good first issue Good for newcomers improvement Improvement to the existing platform front-end Issue related to the React Front End Dashboard labels Jun 11, 2024
@kyle-ssg kyle-ssg linked a pull request Jul 31, 2024 that will close this issue
4 tasks
@rolodato
Copy link
Member

rolodato commented Aug 14, 2024

@kyle-ssg Apologies, I wasn't able to review this before it was merged. A custom Flagsmith-on-Flagsmith API URL is optional and is not provided by default in our Docker Compose setup, which is a common entrypoint for self-hosting customers. Customers without a custom Flagsmith-on-Flagsmith URL will still see the default Edge API URLs.

Is it feasible to use the actual Flagsmith API URL instead of whatever is being used for Flagsmith-on-Flagsmith? I have a similar need when deriving SAML ACS URLs here: #4494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard good first issue Good for newcomers improvement Improvement to the existing platform
Projects
None yet
5 participants