fix(versioning): ensure that audit log record is created when committing versions via CR #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est with versions
matthewelwell
requested review from
a team and
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4091 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 1149 1149
Lines 37589 37596 +7
=======================================
+ Hits 36252 36259 +7
Misses 1337 1337 ☔ View full report in Codecov by Sentry. |
zachaysan
reviewed
Jun 3, 2024
Comment on lines
+173
to
+175
| environment_feature_version_published.send( | ||
| EnvironmentFeatureVersion, instance=environment_feature_version | ||
| ) |
There was a problem hiding this comment.
I can't see from this review where environment_feature_version_published is actually coming from.
zachaysan
approved these changes
Jun 3, 2024
matthewelwell
deleted the
fix(versioning)/ensure-publish-signal-sent-on-cr-commit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This PR ensures that the correct
environment_feature_version_publishedsignal is sent when we publish a ChangeRequest that includes EnvironmentFeatureVersion objects.How did you test this code?
Added new test