Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit log click target for environment too large #4089

Closed
1 of 4 tasks
rolodato opened this issue Jun 3, 2024 · 0 comments · Fixed by #4104
Closed
1 of 4 tasks

Audit log click target for environment too large #4089

rolodato opened this issue Jun 3, 2024 · 0 comments · Fixed by #4104
Assignees
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Member

rolodato commented Jun 3, 2024

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

In the list of audit logs, within a single entry, there are 2 click targets: one to visit the actual audit log entry, and another one to visit the environment that the entry is about. Here is the click target to view the current environment - clicking anywhere else will open the audit log entry:

image

I've had it happen way too often that I accidentally click on the blank area next to the environment name, and it opens the environment instead of the audit log entry. The vast majority of users opening the audit log will want to look at audit log entries and not a specific environment.

Steps To Reproduce

  1. Go to Audit Log
  2. Click on the blank space between the environment name and the entry description

The environment opens and not the audit log entry, which is unexpected.

Expected behavior

There are 2 alternatives I've considered here:

  1. Change the click target for the environment name to only include the environment name itself, and not any blank space
  2. Remove the click target for the environment altogether, and add a link to the relevant environment from within the audit log entry as shown here ("Development" here is not a link to anything):

image

I would prefer option 2 as there is no visual indication that there are different click targets, besides looking at the browser's target link when hovering. Once a user has identified the entry they need (without needing to worry about misclicking), they can drill down into the environment from the audit log entry if needed.

Screenshots

No response

@rolodato rolodato added the bug Something isn't working label Jun 3, 2024
@kyle-ssg kyle-ssg self-assigned this Jun 4, 2024
@kyle-ssg kyle-ssg linked a pull request Jun 4, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants