-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add UI for configuring SAML in Flagsmith #4055
feat: Add UI for configuring SAML in Flagsmith #4055
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Uffizzi Preview |
@novakzaballa I've fixed a couple of minor issues here, but there are some fundamental issues that need resolving. We will, for example, need to add a new endpoint in the SAML repository (which I will work on now). |
I've added a new list endpoint in the PR here which we will need to update this code to use. It's also worth noting that we allow multiple Some other changes that will need to be made:
We should also note that (in the near future), we will want to also be able to manage a list of attribute mappings (which consist of a string input, and a select box (values TBC). So we should consider that when designing the UI to allow for multiple SamlConfiguration objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the UI aspects and all seems good now.
Added a few comments for some typos / improvements to the documentation.
docs/docs/system-administration/authentication/01-SAML/index.md
Outdated
Show resolved
Hide resolved
docs/docs/system-administration/authentication/01-SAML/index.md
Outdated
Show resolved
Hide resolved
docs/docs/system-administration/authentication/01-SAML/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one more minor typo (which I'll fix now)
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
saml_configuration
flag.How did you test this code?