-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set billing starts at to reasonable default for API usage notifications #4054
fix: Set billing starts at to reasonable default for API usage notifications #4054
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/organisations/views.py
Did you find this useful? React with a 👍 or 👎 |
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 1146 1146
Lines 37386 37388 +2
=======================================
+ Hits 36048 36050 +2
Misses 1338 1338 ☔ View full report in Codecov by Sentry. |
I don't think this is actually true since most subscriptions are on the 'free' plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve and merge this for now because I think it's not relevant to organisations on the free plan, but we should discuss when you're around @zachaysan .
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Set billing starts at to reasonable default for API usage notifications. This shouldn't be common in practice since most subscriptions set a billing period. Solves this Sentry issue.
How did you test this code?
N/A