Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean feature state changes in versioning v2 are not saved to audit logs #4051

Closed
1 of 4 tasks
rolodato opened this issue May 29, 2024 · 1 comment · Fixed by #4076
Closed
1 of 4 tasks

Boolean feature state changes in versioning v2 are not saved to audit logs #4051

rolodato opened this issue May 29, 2024 · 1 comment · Fixed by #4076
Assignees
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Member

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

See reproduction steps.

Steps To Reproduce

  1. Go to any environment with Versioning v2 enabled
  2. Change the boolean state of any feature (not the remote config value) and save changes

This change is not reflected in the audit log.

Expected behavior

All changes should be saved to the audit log.

Screenshots

v2-audit-log.mov
@rolodato rolodato added the bug Something isn't working label May 29, 2024
@matthewelwell
Copy link
Contributor

This behaviour is being resolved as follows:

  1. I have added logic to create an audit log record when a new version is published for a given feature
  2. This audit log record will link directly to the history to show the change details in the new version

The first PR for this is here: #4064, the next stage is to implement the FE.

@kyle-ssg I'm using this issue here to provide the information about the changes we discussed earlier today.

Some details you will need to know:

  1. The AuditLog record will have related_object_type=EF_VERSION and related_object_uuid=<uuid> - this will be how you determine the uuid to link to the new version page we discussed.
  2. The endpoint to retrieve a feature version has been added (you can see it here) and includes the previous_version_uuid attribute which you can use to get the previous version for comparison purposes.

@matthewelwell matthewelwell added this to the Front End ToDo milestone May 31, 2024
@kyle-ssg kyle-ssg closed this as completed Jun 4, 2024
@kyle-ssg kyle-ssg linked a pull request Jun 4, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants