Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry-FLAGSMITH-API-4FY): resolve metadata segment n+1 #4030

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented May 27, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

fixes: https://flagsmith.sentry.io/issues/5385839623/
Fix segment metadata n+1 issue by prefetching metadata

How did you test this code?

Updated the unit test

Fix segment metdata n+1 issue by prefetching metadata
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:32am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:32am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 6:32am

Copy link
Contributor

github-actions bot commented May 27, 2024

Uffizzi Preview deployment-52277 was deleted.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (50cc369) to head (14eeaa6).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4030      +/-   ##
==========================================
+ Coverage   96.41%   96.43%   +0.02%     
==========================================
  Files        1145     1149       +4     
  Lines       37295    37535     +240     
==========================================
+ Hits        35959    36198     +239     
- Misses       1336     1337       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi requested review from a team and khvn26 and removed request for a team May 28, 2024 02:23
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just missing typing on one test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants