-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sentry-FLAGSMITH-API-4FY): resolve metadata segment n+1 #4030
Conversation
Fix segment metdata n+1 issue by prefetching metadata
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4030 +/- ##
==========================================
+ Coverage 96.41% 96.43% +0.02%
==========================================
Files 1145 1149 +4
Lines 37295 37535 +240
==========================================
+ Hits 35959 36198 +239
- Misses 1336 1337 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just missing typing on one test
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
fixes: https://flagsmith.sentry.io/issues/5385839623/
Fix segment metadata n+1 issue by prefetching metadata
How did you test this code?
Updated the unit test