Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature states in versioning v2 environments fail to update if modal is not closed #4025

Closed
1 of 4 tasks
rolodato opened this issue May 24, 2024 · 1 comment · Fixed by #4076
Closed
1 of 4 tasks
Assignees
Labels
bug Something isn't working

Comments

@rolodato
Copy link
Member

rolodato commented May 24, 2024

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

In versioning v2 environments, trying to update the same feature without first closing the modal results in a 404, which forever blocks the "Update Feature Value" button until the page is fully reloaded.

Steps To Reproduce

See video below.

  1. Open any feature in an environment with versioning v2 enabled
  2. Update the flag value to anything, save changes
  3. Update the flag again, save changes again

Saving changes fails with a 404, and the Save button is forever stuck until the page is fully reloaded - see #4026.

Expected behavior

Saving the feature state should not fail.

Screenshots

v2.feature.update.mov
@rolodato rolodato added the bug Something isn't working label May 24, 2024
@matthewelwell
Copy link
Contributor

@kyle-ssg can you look into this tomorrow? Although we might be better off investing time in reworking the FE to use the new attributes I added in a PR here to allow the FE to create a new version in a single endpoint.

@kyle-ssg kyle-ssg linked a pull request Jun 3, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants